Allow RedisCacheStore to fail safely when maximum client connections reached #37085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #37337
Summary
Recently I encountered a service interruption relating to Heroku Redis, which I use for caching. The Redis server returned
ERR max number of clients reached
. Redis Cache Store has failsafes to make sure data is still returned when Redis suffers connection errors, but the max number of clients reached error is not aRedis::ConnectionError
, it is instead aRedis::CommandError
. Instead of being returned fresh data from the database, my users were sent 500 errors.This fix simply changes the rescue to save requests from all Redis errors. Of course, errors are still reported to the error handler that can be registered so errors will still be sent via the method a user chooses. This is consistent with the other caching stores, which save from virtually all errors:
Dalli::DalliError
).Redis::BaseError
.