Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the new npm package names in the upgrade guide #37131

Conversation

rmacklin
Copy link
Contributor

@rmacklin rmacklin commented Sep 4, 2019

Summary

As I was upgrading a rails 5.2 app to 6.0, I had to manually rename all references to the old npm packages (in the package.json dependencies and in my app's import statements) to the new package names under the @rails scope, as outlined in #34905:

actioncable   → @rails/actioncable
activestorage → @rails/activestorage
rails-ujs     → @rails/ujs

I thought it would be helpful to specifically mention this in the upgrade guide, so that's what this PR does. (I didn't include the actiontext → @rails/actiontext rename in the upgrade guide since actiontext didn't exist in rails 5.2.)

@rails-bot rails-bot bot added the docs label Sep 4, 2019
@georgeclaghorn georgeclaghorn merged commit d03d6fc into rails:master Sep 4, 2019
@rmacklin rmacklin deleted the document-new-npm-packages-in-upgrade-guide branch September 4, 2019 20:12
kamipo pushed a commit that referenced this pull request Sep 5, 2019
…upgrade-guide

Document the new npm package names in the upgrade guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants