Skip insert all tests when features are unavailable #37170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are causing the Ruby master build to fail in CI. The Docker image we use is based on Ubuntu Bionic which provides SQLite 3.22.0, and the features required to use `insert_all` and `upsert_all` are not available in that version.
eugeneius
pushed a commit
that referenced
this pull request
Apr 16, 2020
Skip insert all tests when features are unavailable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests added in #37154 are causing the Ruby master build to fail in CI. The Docker image we use is based on Ubuntu Bionic which provides SQLite 3.22.0, and the features required to use
insert_allandupsert_allare not available in that version.https://packages.ubuntu.com/bionic/libsqlite3-0
https://sqlite.org/lang_UPSERT.html