Clear query cache when insert all is used #37154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `InsertAll` class currently calls `exec_query`, which doesn't give the query cache enough information to know that it needs to be cleared. By adding an `exec_insert_all` method that calls `exec_query` internally we can configure the query cache to clear when that method is called.
kamipo
added a commit
that referenced
this pull request
Sep 9, 2019
Clear query cache when insert all is used
suketa
added a commit
to suketa/rails_sandbox
that referenced
this pull request
Mar 22, 2020
Clear query cache when insert all is used rails/rails#37154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37142.
The
InsertAllclass currently callsexec_query, which doesn't give the query cache enough information to know that it needs to be cleared.By adding an
exec_insert_allmethod that callsexec_queryinternally we can configure the query cache to clear when that method is called.