Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Migration number to ensure consistency on the document [ci skip] #38311

Merged
merged 1 commit into from Jan 25, 2020

Conversation

davidauza-engineer
Copy link
Contributor

Summary

Hi

I did update the guide called 'Active Record Associations' on the document called 'associations_basics.md' to:

  • Ensure consistency on the document as there were cases where Migration did show 5.0 and other cases where it did show 5.2

  • Keep the documentation updated with the cutting edge versions of the rails products.

  • Ensure newcomer readers have consistent and up to date documentation that prevents them from being confused.

Other Information

Thank you, please let me know your comments.

Kind regards from Colombia,

David Auza

@rails-bot rails-bot bot added the docs label Jan 25, 2020
@vipulnsward
Copy link
Member

There is one more occurrence in

class CreatePublications < ActiveRecord::Migration[5.0]
can you update that as well?

@davidauza-engineer
Copy link
Contributor Author

Sure thing @vipulnsward , it will be ready in a few minutes :)

@davidauza-engineer
Copy link
Contributor Author

Hi @vipulnsward. The suggested change has been made :)

@vipulnsward
Copy link
Member

Thanks, can you squash the commits?

…i skip]

Updated Migration number to 6.0 as there were cases where it did show 5.0 and 5.2 which may lead to confusion on a newcomer reader.
@davidauza-engineer
Copy link
Contributor Author

Hi @vipulnsward

Both commits were squashed as suggested ✅

@vipulnsward vipulnsward merged commit 8ae8e19 into rails:master Jan 25, 2020
@vipulnsward
Copy link
Member

Thanks!

@davidauza-engineer
Copy link
Contributor Author

Thank you very much for the merge @vipulnsward.

Best regards from Colombia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants