New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot pass options to cache_store memory_store #38532
Comments
@kritik mind posting an app that reproduces this error please? |
@hahmed do you want zip file or repo? |
@kritik if you can post a link to a Github repo that would be nice, once the issue is replicated, I can have a look into the issue 👍🏼 |
@hahmed, will do but @eugeneius patch seems to be working |
@hahmed Here's repo https://github.com/kritik/rails_cache_example |
@hahmed Yes, you're right. It works! So, stable is not so stable? :) Seems this ticket and pull request are unnecessary anymore, however I would put that commit to stable branch as well. |
Glad we could get to the bottom of the issue!
No idea what the convention is on that, will leave to the rails team to comment on that. |
I think allowing nested array parameters is almost useless.
Steps to reproduce
1.In Gemile
gem 'rails', git: 'https://github.com/rails/rails.git', branch: '6-0-stable'
2. in development.rb
config.cache_store = :memory_store, { size: 64.megabytes }
as proposed in guides.3. rails s
Seems that this commit sends several params to cache store. But MemoryStore is not updated to receive more params https://github.com/rails/rails/blob/master/activesupport/lib/active_support/cache/memory_store.rb#L21
Expected behavior
Rails should be started
Actual behavior
/memory_store.rb:21:in `initialize': wrong number of arguments (given 2, expected 0..1) (ArgumentError)
System configuration
Rails version: 6.0.2.1 eef309e
Ruby version:
ruby -v
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18]
Last lines
The text was updated successfully, but these errors were encountered: