Fix rescue_from documentation in Action Cable Overview guide [ci skip]
#38781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a minor typo made in d2571e5. The actual method name is `rescue_from` (`with` is one of its parameters), as seen in the examples below these two sentences. [ci skip]
in the Action Cable Overview guide If we want to link to the `rescue_from` API docs, it makes more sense to do it the first time we mention `rescue_from` rather than the second time. [ci skip]
|
Thanks ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This corrects a minor typo made in d2571e5 (#34917). The docs mentioned
rescue_with, but the actual method name isrescue_from(withis one of its parameters), as seen in the examples just below these two sentences.Other Information
I also noticed that we were linking to the
rescue_fromAPI docs in the second mention ofrescue_from. I think it's conventional to link to an external reference the first time the subject is mentioned, so I moved this link accordingly.