Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rescue_from documentation in Action Cable Overview guide [ci skip] #38781

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Fix rescue_from documentation in Action Cable Overview guide [ci skip] #38781

merged 2 commits into from
Mar 21, 2020

Commits on Mar 20, 2020

  1. Change rescue_with -> rescue_from in Action Cable Overview guide 

    This was a minor typo made in d2571e5.
The actual method name is `rescue_from` (`with` is one of its
parameters), as seen in the examples below these two sentences.

[ci skip]
    @rmacklin
    rmacklin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    2647822 View commit details
    Browse the repository at this point in the history

  2. Move the rescue_from API docs link to the first mention of it 

    in the Action Cable Overview guide

If we want to link to the `rescue_from` API docs, it makes more sense to
do it the first time we mention `rescue_from` rather than the second
time.

[ci skip]
    @rmacklin
    rmacklin committed Mar 20, 2020
    Configuration menu
    Copy the full SHA
    0c3f320 View commit details
    Browse the repository at this point in the history