Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example how to change column in "change_table" block #38851

Merged
merged 1 commit into from Mar 31, 2020

Conversation

morgoth
Copy link
Member

@morgoth morgoth commented Mar 31, 2020

Listed examples were missing an example how to simply change definition of existing column

# ====== Change type of a column
#
# change_table(:suppliers) do |t|
# t.change :metadata, :jsonb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use :json instead of :jsonb which is only available for PostgreSQL?
And add [ci skip] for the doc only change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kamipo done both.
I thought that [ci skip] stopped working after switching from Travis to Buildkite?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least [ci skip] is working on the commit 835cf76.

@morgoth morgoth force-pushed the change-example-in-change-table branch from 56131ca to 46b8934 Compare March 31, 2020 08:28
@kamipo kamipo merged commit c805c5a into rails:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants