Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. #3946

pokonski · 2011-12-12T15:43:05Z

This pull request fixes generation of asset paths inside assets when deploying to sub-URI.
For example when our app is deployed inside /community this

/* app/assets/stylesheets/application.css.erb */
body{
  background: url(<%= image_path "bg.png" %>);
}

Now produces a proper path:

body{
  background: url(/community/assets/bg.png);
}

instead of /assets/bg.png.

Precompilation:

Also works!

RAILS_RELATIVE_URL_ROOT="/community" bundle exec rake assets:precompile

guilleiguaran · 2011-12-12T15:44:43Z

Please can you rebase with master?

Github reports that this pull request cannot be automatically merged.

guilleiguaran · 2011-12-12T15:46:46Z

My vote is +1 to this

kennyj · 2011-12-12T15:49:49Z

+1
cool!! we'll close many issues.

pokonski · 2011-12-12T16:00:24Z

I've made quite a mess. Can you try now?

guilleiguaran · 2011-12-12T16:02:43Z

Now can be merged but you can squash your commits in one and force push (git push -f)? (to avoid have the "Merge master", "Merge conflict" and the repeated "Add a test case for RAILS_RELATIVE_URL_ROOT" commits)

A tutorial to do it: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

pokonski · 2011-12-12T16:13:27Z

It's fixed now ;)

guilleiguaran · 2011-12-12T16:15:42Z

Yeah, now it's great and ready to be merged :D

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"].

sergiocampama · 2012-02-01T12:56:52Z

Sorry, but with this am I still supposed to use config.assets.prefix? I thought that by only specifying config.relative_url_root in application.rb everything (routes, assets and everything) would detect that rails is running on a subfolder and react accordingly.

Is there any documentation as to how to really use a rails 3.2.1 app inside a subfolder?

pokonski · 2012-02-01T13:21:16Z

@sergiocampama do you use Passenger? If so you don't need to configure config.assets.prefix. Only environmental variable is needed for precompiling assets.

sergiocampama · 2012-02-01T13:33:49Z

no, i'm using nginx + thin

when precompiling, the assets get generated on the public folder? (I haven't really released my app yet, I'm only in development mode) if that's the case, then I see how it should work. But I still need config.assets.prefix in development mode, so that should go in environments/development.rb, right?

pokonski · 2012-02-01T13:38:29Z

Once precompiled they land in public/assets. I don't know how you configured your nginx so can't help you precisely. But you should not touch config.assets.prefix at all.

http://guides.rubyonrails.org/configuring.html says:

config.action_controller.relative_url_root can be used to tell Rails that you are deploying to a subdirectory. The default is ENV['RAILS_RELATIVE_URL_ROOT']

Try and set that in environments/development.rb. Also notice the action_controller part, it's important.

ndbroadbent · 2012-03-21T13:19:55Z

Hello, RAILS_RELATIVE_URL_ROOT is not working for me in Rails 3.2.2, with rake assets:precompile.

I have a file at assets/stylesheets/common.scss.erb, which contains the line:

background: url("<%= image_path "asterisk.gif" %>") ...

When I run bundle exec rake assets:precompile RAILS_RELATIVE_URL_ROOT='/sub_uri', the generated application.css contains background:url("/assets/asterisk.gif"), instead of background:url("/sub_uri/assets/asterisk.gif").

So, I want asterisk.gif to be copied to public/assets/asterisk.gif, but I need the URL to be /sub_uri/assets/asterisk.gif, since we use RailsBaseURI /sub_uri with Passenger.

Any help would be appreciated!

pokonski · 2012-03-21T13:20:55Z

It should be:
RAILS_RELATIVE_URL_ROOT='/sub_uri' bundle exec rake assets:precompile

ndbroadbent · 2012-03-21T13:30:47Z

Nope, I'm afraid that doesn't make a difference. Image paths are still missing /sub_uri

ndbroadbent · 2012-03-21T13:32:48Z

I should mention that I have the following line in application.rb:

config.assets.initialize_on_precompile = false

I am not initializing the environment for asset precompiling, and I cannot because it crashes on Heroku when the production database is not configured.

josevalim · 2012-03-21T13:35:07Z

Does it work if that configuration option is true on your local machine? If so, we have found the reason for the bug. Although I would suggest for you to configure it via config.relative_url_root instead of an environment variable.

pokonski · 2012-03-21T13:36:35Z

Wait a second. So is it Passenger or Heroku?

ndbroadbent · 2012-03-21T13:38:55Z

I'm afraid it's both... It's an open source application that needs to support all deployment strategies. So if a solution won't work for Heroku (without relative_url_root), then we can't use it with Passenger (with relative_url_root)

ndbroadbent · 2012-03-21T13:47:37Z

@josevalim: Yes, it does work with config.assets.initialize_on_precompile = true.

ndbroadbent · 2012-03-21T14:03:06Z

@josevalim - In recent versions of Rails, we were able to set config.assets.initialize_on_precompile = true without the production database configured, and assets:precompile didn't complain as long as we didn't autoload any models.

However, that seems to have changed in 3.2 - when Application.initialize! is called, it crashes instantly with the following backtrace:

rake aborted!
FATAL:  database "fat_free_crm_production" does not exist
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/postgresql_adapter.rb:1194:in `initialize'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/postgresql_adapter.rb:1194:in `new'
... etc.
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/postgresql_adapter.rb:28:in `postgresql_connection'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/abstract/connection_pool.rb:277:in `new_cshould I work on onnection'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/abstract/connection_pool.rb:287:in `checkout_new_connection'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/connection_adapters/abstract/connection_specification.rb:142:in `connection'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/activerecord-3.2.2/lib/active_record/model_schema.rb:308:in `clear_cache!'
... etc.
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.2.2/lib/rails/initializable.rb:54:in `run_initializers'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.2.2/lib/rails/application.rb:136:in `initialize!'
/home/ndbroadbent/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.2.2/lib/rails/railtie/configurable.rb:30:in `method_missing'
/home/ndbroadbent/code/rails/fat_free_crm/config/environment.rb:5:in `<top (required)>'
...

What would you advise for my situation? Is it logical for Rails to support loading the environment without a database, or could Sprockets also handle the RAILS_RELATIVE_URL_ROOT env variable?

andywenk · 2013-05-22T16:49:08Z

@ndbroadbent I hade the same issue . The problem is definitely

 config.assets.initialize_on_precompile = true

I removed it in config/environments/development.rb, set

 config.action_controller.relative_url_root = "/some_path"

and ran

 bundle exec rake assets:precompile RAILS_ENV=development

That worked for me.

botimer · 2013-07-09T13:52:00Z

I am seeing on Rails 3.2.13 that config.assets.initialize_on_precompile = false causes config.relative_url_root to be omitted in compiled assets.

However, RAILS_RELATIVE_URL_ROOT from the environment is being applied to config.relative_url_root as expected. (You can also clearly set this manually.)

As mentioned above, config.action_controller.relative_url_root is the parameter that applies to the asset paths, so I have added one line to production.rb to restore the expected behavior:

config.action_controller.relative_url_root = config.relative_url_root

Default relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. Fixes #3365

5266eb9

josevalim added a commit that referenced this pull request Dec 12, 2011

Merge pull request #3946 from pokonski/relative_root

af308ff

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"].

josevalim merged commit af308ff into rails:master Dec 12, 2011

This was referenced Dec 12, 2011

rake assets:precompile cannot be used with relative url root #2435

Closed

Asset precompilation does not work when deploying under sub-path #3259

Closed

brianpattison mentioned this pull request Mar 19, 2014

Use font-url path for proper asset compiling FortAwesome/font-awesome-sass#20

Merged

wvengen mentioned this pull request Jun 16, 2014

Assets when running on suburi foodcoops/foodsoft#283

Open

ipmsteven mentioned this pull request Dec 15, 2017

asset paths inside assets when deploying to sub-url rails/webpacker#1106

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. #3946

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. #3946

pokonski commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

kennyj commented Dec 12, 2011

pokonski commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

pokonski commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

sergiocampama commented Feb 1, 2012

pokonski commented Feb 1, 2012

sergiocampama commented Feb 1, 2012

pokonski commented Feb 1, 2012

ndbroadbent commented Mar 21, 2012

pokonski commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

josevalim commented Mar 21, 2012

pokonski commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

andywenk commented May 22, 2013

botimer commented Jul 9, 2013

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. #3946

Fix #3365. Default config.relative_url_root to ENV["RAILS_RELATIVE_URL_ROOT"]. #3946

Conversation

pokonski commented Dec 12, 2011

Precompilation:

guilleiguaran commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

kennyj commented Dec 12, 2011

pokonski commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

pokonski commented Dec 12, 2011

guilleiguaran commented Dec 12, 2011

sergiocampama commented Feb 1, 2012

pokonski commented Feb 1, 2012

sergiocampama commented Feb 1, 2012

pokonski commented Feb 1, 2012

ndbroadbent commented Mar 21, 2012

pokonski commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

josevalim commented Mar 21, 2012

pokonski commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

ndbroadbent commented Mar 21, 2012

andywenk commented May 22, 2013

botimer commented Jul 9, 2013