Rescue Database errors during active_record.define_attribute_methods #40119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This initializer should be best effort. If for some reason the database in unhealthy, it is better to move forward with the boot process than to crash.
casperisfine
force-pushed
the
rescue-db-errors-during-eager-load
branch
from
91973a3
to
36fae4b
Compare
This was referenced Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #40110 and #40108
This initializer should be best effort. If for some reason the database in unhealthy, it is better to move forward with the boot process than to crash.
Ideally if the schema cache dump was loaded, we should be able to define the attribute methods without having to connect to the database, however
define_attribute_methodscall various methods that access the schema cache throughBase.connectionwhich does immediately connect to the database. I'd like to refactor that, but it's much more work. So short term handling errors is the best we can do.cc @rafaelfranca @Edouard-chin