Make Active Record adapters connections lazy #42251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
lazy-adapters
branch
3 times, most recently
from
1f23b7d
to
71b1c91
Compare
casperisfine
force-pushed
the
lazy-adapters
branch
from
71b1c91
to
5a06ce5
Compare
|
I still need to convert the postgres adapter, but the general idea is there. |
casperisfine
force-pushed
the
lazy-adapters
branch
from
caed303
to
5a06ce5
Compare
Hum, it's going to be a very tricky one. It has much more state initialized from the connection than other adapters :/ |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is a rebase of an old branch: https://github.com/Shopify/rails/tree/lazy-connection.
Related: #42085
For resiliency reasons, it is paramount that Rails is able to boot even if it can't connect to the database, right now it is achieved by skipping Active Record attribute methods definition if an error happens (Ref: #40119).
But for historical reason, lots of important data is held by the
Adapterand accessed throughActiveRecord::Base.connection, and that later does eagerly connect to the database.If the
Adapterwould only connect when necessary, it would make it much easier to initialize the application without having a dependency on the database.