Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests in master #40271

Merged
merged 1 commit into from Sep 22, 2020
Merged

Conversation

pftg
Copy link
Contributor

@pftg pftg commented Sep 22, 2020

Restores environments before testing their settings

@rails-bot rails-bot bot added the railties label Sep 22, 2020
@pftg pftg changed the title WIP: Restores environments before testing their settings WIP: Fixes tests in maste Sep 22, 2020
@pftg pftg changed the title WIP: Fixes tests in maste WIP: Fixes tests in master Sep 22, 2020
@pftg pftg changed the title WIP: Fixes tests in master Fixes tests in master Sep 22, 2020
@pftg
Copy link
Contributor Author

pftg commented Sep 22, 2020

@rafaelfranca please check

@rafaelfranca
Copy link
Member

This change makes no sense to me. No config is being changed, so why do we need to restore?

@pftg
Copy link
Contributor Author

pftg commented Sep 22, 2020

by default, there is no config/environments in the app_path, but in order to verify commit with new test we need to load config/environments/production.rb, that's why I assume better to restore config/environments from config/__environments__.

There are similar tests with this trick

@rafaelfranca
Copy link
Member

Oh, yeah, just saw that. Thanks.

@rafaelfranca rafaelfranca merged commit 0979a16 into rails:master Sep 22, 2020
@pftg pftg deleted the fix-tests-in-master branch September 22, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants