Make sure log level in development is debug

Laso make sure the tests are actually checking the log level of the app, not the one we set in the test helper.
rails · Sep 22, 2020 · 7307994 · 7307994
1 parent 70018f8
commit 7307994
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/railties/lib/rails/application/configuration.rb b/railties/lib/rails/application/configuration.rb
@@ -43,7 +43,7 @@ def initialize(*)
         @session_store                           = nil
         @time_zone                               = "UTC"
         @beginning_of_week                       = :monday
-        @log_level                               = :info
+        @log_level                               = :debug
         @generators                              = app_generators
         @cache_store                             = [ :file_store, "#{root}/tmp/cache/" ]
         @railties_order                          = [:all]

diff --git a/railties/test/application/configuration_test.rb b/railties/test/application/configuration_test.rb
@@ -1577,8 +1577,15 @@ def index
       assert_equal session_options, app.config.session_options
     end
 
-    test "config.log_level defaults to info" do
-      make_basic_app
+    test "config.log_level defaults to debug in development" do
+      app "development"
+
+      assert_equal Logger::DEBUG, Rails.logger.level
+    end
+
+    test "config.log_level default to info in production" do
+      app "production"
+
       assert_equal Logger::INFO, Rails.logger.level
     end
 

diff --git a/railties/test/isolation/abstract_unit.rb b/railties/test/isolation/abstract_unit.rb
@@ -206,7 +206,6 @@ def build_app(options = {})
         config.session_store :cookie_store, key: "_myapp_session"
         config.active_support.deprecation = :log
         config.action_controller.allow_forgery_protection = false
-        config.log_level = :info
       RUBY
     end