Make sure that ActionView::Helpers::AssetTagHelper.preload_links_header is nil without Rails 6.1 defaults
#41052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der` `nil` without Rails 6.1 defaults In rails#39939 we automatically set `Link` header for each stylesheet and script. In rails#40882 we added `config.action_view.preload_links_header` option to configure whether `stylesheet_link_tag` and `javascript_include_tag` should set automatically `Link` header. This commit adds test to make sure that it is disabled by default for updated apps that haven't adopted new '6.1' defaults. Also, added changes to Configuring guide - Mentioned this option in "Results of `config.load_defaults`" section - Mentioned this option in "Baseline defaults:" section (see ff88113)
bogdanvlviv
changed the title
ActionView::Helpers::AssetTagHelper.preload_links_header nil without Rails 6.1 defaultsActionView::Helpers::AssetTagHelper.preload_links_header is nil without Rails 6.1 defaults
rafaelfranca
added a commit
that referenced
this pull request
Jan 8, 2021
…fication Make sure that `ActionView::Helpers::AssetTagHelper.preload_links_header` is `nil` without Rails 6.1 defaults
|
It would be nice if the asset helpers had a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #39939 we automatically set
Linkheader for each stylesheet and script.In #40882 we added
config.action_view.preload_links_headeroptionto configure whether
stylesheet_link_tagandjavascript_include_tagshould set automatically
Linkheader.This commit adds test to make sure that it is disabled by default
for updated apps that haven't adopted new '6.1' defaults.
Also, added changes to Configuring guide
config.load_defaults" section/cc @pixeltrix