Add config.action_view.preload_links_header option
#40882
Merged
+186
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is missing documentation of |
pixeltrix
force-pushed
the
add-preload-links-header-config
branch
from
e438206
to
cffdc5c
Compare
PR #39939 added support for the `Link` header being generated automatically when using `stylesheet_link_tag` and `javascript_include_tag`. However not everything should be preloaded, e.g. a link to a legacy IE stylesheet has no need to be preloaded because IE doesn't support the header and in some browsers it will trigger the preload even though it's not used since it's inside an IE conditional comment. This leads to increased bandwith costs and slower application performance. To allow more flexibility for sites that may have complex needs for the `Link` header this commit adds a configuration option that disables it completely and leaves it up to the application to decide how to handle generating a `Link` header.
pixeltrix
force-pushed
the
add-preload-links-header-config
branch
from
cffdc5c
to
200083c
Compare
|
@rafaelfranca Added to the 6.1 release notes and the configuration guide - was there anywhere else you were thinking? I wondered whether to add it to the assets.rb initializer as a commented out option to turn it off so that it's a bit more visible but decided against it since it seemed a bit tangential to assets and don't really want to put it in an initializer by itself. |
bogdanvlviv
added a commit
to bogdanvlviv/rails
that referenced
this pull request
Jan 8, 2021
…der` `nil` without Rails 6.1 defaults In rails#39939 we automatically set `Link` header for each stylesheet and script. In rails#40882 we added `config.action_view.preload_links_header` option to configure whether `stylesheet_link_tag` and `javascript_include_tag` should set automatically `Link` header. This commit adds test to make sure that it is disabled by default for updated apps that haven't adopted new '6.1' defaults. Also, added changes to Configuring guide - Mentioned this option in "Results of `config.load_defaults`" section - Mentioned this option in "Baseline defaults:" section (see ff88113)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #39939 added support for the
Linkheader being generated automatically when usingstylesheet_link_tagandjavascript_include_tag. However not everything should be preloaded, e.g. a link to a legacy IE stylesheet has no need to be preloaded because IE doesn't support the header and in some browsers it will trigger the preload even though it's not used since it's inside an IE conditional comment. This leads to increased bandwith costs and slower application performance.To allow more flexibility for sites that may have complex needs for the
Linkheader this commit adds a configuration option that disables it completely and leaves it up to the application to decide how to handle generating aLinkheader.NOTE: The intention is to backport this to 6-1-stable and add a new entry to
new_framework_defaults_6_1.rbso that upgrading applications can opt into the default option of it being enabled since they're the most likely to be affected by the legacy IE issue.