Add missing require to hash_with_indifferent_access #41707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requiring only "active_support/hash_with_indifferent_access", calling `slice!` method on `HashWithIndifferentAccess` object causes `NoMethodError`. This is caused by `slice!` method calls `super` which is defined in "active_support/core_ext/hash/slice" that' not required by this file. Adding `require "active_support/core_ext/hash/slice"` to hwia resolves this issue. Note: since all tests `require_relative "abstract_unit"` that requires "active_support/core_ext/hash/slice" eventually, it's pretty hard to test method behavior without require.
okuramasafumi
deleted the
add-missing-require-to-hash_with_indifferent_access
branch
kamipo
added a commit
that referenced
this pull request
Mar 22, 2021
…ash_with_indifferent_access Add missing require to hash_with_indifferent_access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When requiring only "active_support/hash_with_indifferent_access",
calling
slice!method onHashWithIndifferentAccessobjectcauses
NoMethodError.This is caused by
slice!method callssuperwhich is definedin "active_support/core_ext/hash/slice" that' not required by this file.
Adding
require "active_support/core_ext/hash/slice"to hwiaresolves this issue.
Note: since all tests
require_relative "abstract_unit"that requires"active_support/core_ext/hash/slice" eventually, it's pretty hard to
test method behavior without require.