Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -e option instead of -c option (rake rdoc task). #4278

Merged
merged 1 commit into from
Jan 3, 2012

Conversation

kennyj
Copy link
Contributor

@kennyj kennyj commented Jan 3, 2012

If we set ISO-8859-1 (excepting utf-8) to LANG environment variable, rake rdoc task is not work fine.

$ export LANG=en_US.ISO-8859-1 ★
$ bundle exec rake rdoc
Parsing sources...
100% [644/644]  RDOC_MAIN.rdoc

Generating SDoc format into /home/kennyj/rails/doc/rdoc...
rake aborted!
incompatible encoding regexp match (UTF-8 regexp with ISO-8859-1 string)

Tasks: TOP => rdoc => doc/rdoc/index.html
(See full trace by running task with --trace)

It seems that "-c" option is not work fine.
With this pull request (instead of using -e (encoding) option).

$ bundle exec rake rdoc
Parsing sources...
100% [644/644]  RDOC_MAIN.rdoc

Generating SDoc format into /home/kennyj/rails/doc/rdoc...

Files:       644

Classes:     369 ( 214 undocumented)
Modules:     353 ( 236 undocumented)
Constants:   214 ( 193 undocumented)
Attributes:  329 ( 309 undocumented)
Methods:    3443 (1653 undocumented)

Total:      4708 (2605 undocumented)
 44.67% documented

Elapsed: 323.7s

I thinks that this issue is related to GH #3743 .

spastorino added a commit that referenced this pull request Jan 3, 2012
Use -e option instead of -c option (rake rdoc task).
@spastorino spastorino merged commit 36e77fe into rails:master Jan 3, 2012
@spastorino
Copy link
Contributor

@kennyj does we need to backport this PR to 3.1? I've already pushed it to 3-2-stable

spastorino added a commit that referenced this pull request Jan 3, 2012
Use -e option instead of -c option (rake rdoc task).
@kennyj
Copy link
Contributor Author

kennyj commented Jan 3, 2012

@spastorino
I think that 3-1-stable has same problem, and this commit seems to be effective (in my environment).
Please merge this PR to 3.1.

p.s.
I think that I fixed 3743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants