Remove warning when overwriting existing scopes #43204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonganger
force-pushed
the
remove_scope_overwrite_warning
branch
from
127f1c0
to
7388f5a
Compare
|
There is a test failing. Can you take a look? |
westonganger
force-pushed
the
remove_scope_overwrite_warning
branch
from
7388f5a
to
af6a242
Compare
westonganger
force-pushed
the
remove_scope_overwrite_warning
branch
from
d53640d
to
0e8432e
Compare
|
Ok tests are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Solves #43163 as approved by @rafaelfranca