Update guide to use the appropriate concurrent-ruby class
#43218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizkowalski
changed the title
luizkowalski
changed the title
concurrent-ruby class
| @@ -289,7 +289,7 @@ Another example, using Concurrent Ruby: | |||
| ```ruby | |||
| Rails.application.executor.wrap do | |||
| futures = 3.times.collect do |i| | |||
| Concurrent::Future.execute do | |||
| Concurrent::Promises.future do | |||
There was a problem hiding this comment.
It looks like we can also replace this usage in the test:
rails/actioncable/test/client_test.rb
Line 204 in 0b5c721
There was a problem hiding this comment.
Good catch, I should've done a global search! updated as well
luizkowalski
force-pushed
the
fix/documentation
branch
from
b1136b2
to
868a63c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Concurrent Ruby's README states that
Concurrent::Futureis being deprecated and users should prefer usingPromisesfactory instead. I updated the guide to reflect thisOther Information
https://github.com/ruby-concurrency/concurrent-ruby#deprecated