QueryMethods#in_order_of drop records not listed

[kddnewton]

in_order_of now filters down to the values provided, to match the behavior of the Enumerable version.

This is in response to #43916 (comment). It's working to match the Enumerable version, but since it was released I'm not sure of the migration path. Maybe it could be considered a bug and be a part of a patch release? Not sure.

[rafaelfranca]

Maybe it could be considered a bug and be a part of a patch release?

That was my plan, specially that it is only release for 3 weeks.

[AlexKovynev]

sorry for interfering, if you plan backport this to 7.0 maybe will be good to not forget backport original PR #43916

[rafaelfranca]

@AlexKovynev not sure if I'm missing something, but I believe that PR is already there.

[chaadow]

Would you guys mind if I added an optional include_all_elements param which basically does not do the where used in this PR.because let's say we have an enum with 6 values :

• I want to order by the first 3, and the rest I don't care about, but I still want them at the end of my relation.
• With how it's done right now, it will never enter the ELSE case. because of the WHERE .. in (..)

[gstokkink]

@chaadow did you get around creating a PR for that? I'd love to have that functionality as well.

[guigs]

@chaadow @gstokkink I was surprised by this behavior too. Here's what I'm using as a workaround:

in_order_of(:priority, %w[urgent high medium]).unscope(where: :priority)

[tiegz]

I'm also curious if an option is in the works -- we're just upgrading to Rails 7.0 now and were surprised that an order predicate would limit rows returned.

[zavan]

I was also surprised by this behavior. @guigs workaround works, you just gotta be careful in case you have another (intentional) where on that column.