Fix QueryMethods#in_order_of to handle empty order list
#43916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: rails#43903 Ref: rails#42061 Simply don't generate the case statement if the order list is empty and fallback to default ordering.
rafaelfranca
added a commit
that referenced
this pull request
Dec 20, 2021
…-array Fix `QueryMethods#in_order_of` to handle empty order list
|
Thanks for the fix @casperisfine, so I missed it in the first place! |
|
Something I noticed from this test is that Active Record's posts = Post.all
posts.in_order_of(:id, order).pluck(:id) # => [3, 4, 1, 2, 5, 6, 7, 8, 9, 10, 11]
posts.to_a.in_order_of(:id, order).pluck(:id) # => [3, 4, 1]I feel like the two methods should be consistent, but I am unsure which is the preferred behavior. Thoughts? |
|
I think it should match the enumerable behavior. |
|
I've added the PR here: #44097. This brings it in line with the enumerable version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #43903
Ref: #42061
Simply don't generate the case statement if the order list is empty
and fallback to default ordering.
cc @kddnewton @kaspth
TODO: