Action controller refactor - remove Compatibility module #4497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already being set by Rails configuration.
render :template => "/foo/bar"
Options :nothing and :text => nil should be handled by ActionController::Rendering instead.
…issing instead Do not create a method_missing method to handle not found actions, use the action_missing method provided by Rails instead.
This seems to be required only when calling render :partial with an empty collection from a controller. This call happens to return no content, letting the response body empty, which means to Rails that it should go on and try to find a template to render based on the current action name, thus failing hard. Although tests keep all green, we need to check a better way to fix this.
This should be set globally as a configuration, using `config.action_dispatch.default_charset` instead
josevalim
added a commit
that referenced
this pull request
Jan 17, 2012
…refactor Action controller refactor - remove Compatibility module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Compatibilitymodule from ActionController, either by cleaning up code that is going to be deprecated in 3.2, or by moving code to their right places inside ActionController modules.I'm sending a second pull request for 3-2-stable branch deprecating most of the methods inside this module.
Please let me know if something should be improved.
Thanks.