Delegate model generator description to orm hooked generator #45315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
hook_generator_description
branch
3 times, most recently
from
88092e3
to
82144bd
Compare
|
I think this will break the resource generator description since it is a subclass. I'll sort that out before merging. |
Use orm hooked generator description for model generator help.
gmcgibbon
force-pushed
the
hook_generator_description
branch
from
82144bd
to
fff53e4
Compare
gmcgibbon
added a commit
to gmcgibbon/rails
that referenced
this pull request
Jul 25, 2022
Removes "#{name}_generator" method for removed hooks introduced in rails#45315
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use orm hooked generator description for model generator help. This should let an ORM configured generator let users know how to use it. The current description only really describes the behaviour of the Active Record generator, so it should own its own description.
This is a potentially breaking change for those with overridden generators, so I would be happy to keep the
USAGEin railties and conditionally delegate to the orm generator if it hasUSAGEinstead.