Require ruby-vips before downloading blob
#45448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that if `download_blob_to_tempfile` raises an error before evaluating its block, `rescue ::Vips::Error` will not cause a `NameError` due to `ruby-vips` not being loaded yet. This also prevents the blob from being downloaded if `ruby-vips` is not available to analyze it. A similar change was made for `Analyzer::ImageAnalyzer::ImageMagick` in rails#45420.
jonathanhefner
force-pushed
the
active_storage-require-vips-before-download
branch
from
21b2fbd
to
c5133f0
Compare
jonathanhefner
added a commit
that referenced
this pull request
Jun 23, 2022
…vips-before-download Require `ruby-vips` before downloading blob (cherry picked from commit d2c5d23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that if
download_blob_to_tempfileraises an error before evaluating its block,rescue ::Vips::Errorwill not cause aNameErrordue toruby-vipsnot being loaded yet.This also prevents the blob from being downloaded if
ruby-vipsis not available to analyze it.A similar change was made for
Analyzer::ImageAnalyzer::ImageMagickin #45420.