Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require ruby-vips before downloading blob #45448

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Require ruby-vips before downloading blob #45448

merged 1 commit into from
Jun 23, 2022

Commits on Jun 23, 2022

  1. Require ruby-vips before downloading blob 

    This ensures that if `download_blob_to_tempfile` raises an error before
evaluating its block, `rescue ::Vips::Error` will not cause a
`NameError` due to `ruby-vips` not being loaded yet.

This also prevents the blob from being downloaded if `ruby-vips` is not
available to analyze it.

A similar change was made for `Analyzer::ImageAnalyzer::ImageMagick`
in rails#45420.
    @jonathanhefner
    jonathanhefner committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    c5133f0 View commit details
    Browse the repository at this point in the history