Remove unnecessary or incorrect calls to connection_handler #45592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an effort to find all the internal callers of `connection_handler` I decided to remove any uses that are either: 1) Unnecessary - we can call what we need on Base or elsewhere without going through the handler 2) Incorrect - there's a better way call the same thing. For exmaple avoiding calling the ivar, and instead calling `send` on an existing method. Doing this will inform us what cases the connection handler is required and how we can expand Base to provide everything an application or gem could need without going through the handler. Reducing calls makes it easier to replace or refactor in the future.
eileencodes
commented
Jul 13, 2022
| @@ -174,8 +174,6 @@ def retrieve_connection(connection_name, role: ActiveRecord::Base.current_role, | |||
| unless pool | |||
| if shard != ActiveRecord::Base.default_shard | |||
| message = "No connection pool for '#{connection_name}' found for the '#{shard}' shard." | |||
| elsif ActiveRecord::Base.connection_handler != ActiveRecord::Base.default_connection_handler | |||
| message = "No connection pool for '#{connection_name}' found for the '#{ActiveRecord::Base.current_role}' role." | |||
There was a problem hiding this comment.
We no longer use multiple handlers to control the pools so we don't need this error anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to find all the internal callers of
connection_handlerIdecided to remove any uses that are either:
going through the handler
avoiding calling the ivar, and instead calling
sendon an existingmethod.
Doing this will inform us what cases the connection handler is required
and how we can expand Base to provide everything an application or gem
could need without going through the handler. Reducing calls makes it
easier to replace or refactor in the future.