Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary or incorrect calls to connection_handler #45592

Commits on Jul 13, 2022

  1. Remove unnecessary or incorrect calls to connection_handler

    In an effort to find all the internal callers of `connection_handler` I
    decided to remove any uses that are either:
    
    1) Unnecessary - we can call what we need on Base or elsewhere without
    going through the handler
    2) Incorrect - there's a better way call the same thing. For exmaple
    avoiding calling the ivar, and instead calling `send` on an existing
    method.
    
    Doing this will inform us what cases the connection handler is required
    and how we can expand Base to provide everything an application or gem
    could need without going through the handler. Reducing calls makes it
    easier to replace or refactor in the future.
    eileencodes committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    baa9040 View commit details
    Browse the repository at this point in the history