Remove ActiveSupport::TestCase#pending, use skip instead
#4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
added a commit
that referenced
this pull request
Jan 21, 2012
Remove ActiveSupport::TestCase#pending, use `skip` instead
|
This needs to be deprecated on 3-2-stable. Otherwise, tests just break when upgrading an app and you have to Google to find out why and how to fix. |
|
@jeremy ok. @rafaelfranca are you already working on this, confirm? |
|
Confirm. I need to discuss it better, but it is almost done. |
|
Ok, if you need anything, just ping me later. Thanks! At. On Friday, May 18, 2012 at 7:14 PM, Rafael Mendonça França wrote:
|
|
I was reviewing my old list of issues and found this one, and I did the changes in this branch, let me know what you think. |
|
👍 |
|
|
carlosantoniodasilva
added a commit
that referenced
this pull request
Nov 18, 2012
Properly deprecate #pending from AS::TestCase. This has been previously removed from master, and is now back with a deprecation instead, to avoid people having tests breaking when upgrading an app. Please check #4575 for more background.
|
Done, thanks! |
sgerrand
pushed a commit
to sgerrand/rails
that referenced
this pull request
Nov 2, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pendingmethod nowadays works basically delegating toskip, so I believe there is no real need to have it. We should just start usingskipdirectly.