stop generating vendor/plugins with new Rails 3.2 applications #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's deprecated, but it still works, I would just do it for master branch. |
|
Yes, can you please send this pull request to |
|
Sure |
|
@parndt ping! |
|
Thanks.. I've been away, will work on this today. |
|
This has already been done in master. dad7fdc :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that use of vendor/plugins is deprecated, should we not stop generating vendor/plugins with new Rails applications?
I know that this lacks fixing any tests that assert that vendor/plugins exists but I thought I'd see if there was support for this idea before spending more time.
Thanks!