new_framework_defaults_7_1.rb are not working as expected

[fatkodima]

Steps to reproduce

1. Create a new (< 7.1) rails app
2. Use config.load_defaults 7.0 in application.rb
3. Add https://github.com/rails/rails/blob/main/railties/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_1.rb.tt to initializers and uncomment commented lines

Expected behavior

For example, in console

ActiveRecord.allow_deprecated_singular_associations_name # => false

Actual behavior

ActiveRecord.allow_deprecated_singular_associations_name # => true

Even though there is a test case for this -

rails/railties/test/application/configuration_test.rb

Lines 2497 to 2507 in cef42e6

	test "ActiveRecord.allow_deprecated_singular_associations_name can be configured via config.active_record.allow_deprecated_singular_associations_name" do
	remove_from_config '.*config\.load_defaults.*\n'
	app_file "config/initializers/new_framework_defaults_7_1.rb", <<-RUBY
	Rails.application.config.active_record.allow_deprecated_singular_associations_name = false
	RUBY
	app "development"
	assert_equal false, ActiveRecord.allow_deprecated_singular_associations_name
	end

The same situation applies for many of the configs in the new_framework_defaults_7_1.rb.tt file.
Am I doing something wrong?

System configuration

Rails version: main

[rafaelfranca]

This usually happen because something in the application is loading ActiveRecord::Base too early. Did you observe this behavior really in a new generated application or did you added any gem after it?

[fatkodima]

Did you observe this behavior really in a new generated application

Rechecked within a completely new app - works as expected.

I originally checked within the existing app. I was able to identify 2 gems that load ActiveRecord::Base too early. Without them - also works as expected.

I am wondering if reassigning a local variable configs here -

rails/activerecord/lib/active_record/railtie.rb

Line 245 in 324880c

configs = configs.except(

, which is used then here -

rails/activerecord/lib/active_record/railtie.rb

Line 234 in 324880c

configs.each do |k, v|

when ActiveRecord::Base is loaded earlier, is intentional? Because without that mutation everything works as expected with that 2 gems.

[mrhead]

Unfortunately, this is a common issue caused by different gems. Another example: rollbar/rollbar-gem#906

I wish Rails would automatically identify issues like this, but I'm unsure how to implement it.

[ghiculescu]

I wish Rails would automatically identify issues like this, but I'm unsure how to implement it.

There's a few ideas floating around. I think my favourite is #45297

@fatkodima are you able to share which gems had issues? Ideally they get patched.

Because without that mutation everything works as expected with that 2 gems.

Actually that reminds me of #46278 - another one caused by a third party issue.

[fatkodima]

One is https://github.com/ledermann/unread, another one is mine - https://github.com/fatkodima/data_checks 😄

Actually that reminds me of #46278 - another one caused by a third party issue.

Ah, yes, haven't seen that. Had exactly the same idea.

[ghiculescu]

I think this is probably what you want the architecture to look like in your gem. But I agree that it would be better if Rails could handle this in more cases.

[fatkodima]

Yes, thanks for looking into this. I will definitely fix my gem and probably send a PR into unread (if no one will outpace me).
I defer loading of Active Record in my other gem with a similar technique you mentioned 👍.

[fatkodima]

Opened a PR in unread and released a new version of data_checks with the fix.
So feel free to close, if no more actions can be taken.

[ghiculescu]

@byroot @rafaelfranca do you think we will make any big changes for this in Rails 7.1?

In any case I will close this particular issue as resolved.

[pbstriker38]

Here's another gem that loads ActiveRecord too early. It seems like they don't want to accept my PR unless I add a way to test it. Any ideas on a good way to test it?

flippercloud/flipper#832

[byroot]

That's not really testable unless you have something like our Railties test that generate and boot an application. But it's very slow and doubt flipper will want just 20 seconds test.