ActiveStorage::MirrorJob always uses the default service, even if overridden via has_*_attached ..., service: :another_service

[jnimety]

I ran into this when trying to migrate all of my attached from local storage to s3. After setting up mirroring and running ActiveStorage::Blob.find_each &:mirror_later I was surprised to find all of my attachments in the default storage service, even if a different service had been specified via has_*_attached ..., service: ...

I think the culprit is here:

rails/activestorage/app/jobs/active_storage/mirror_job.rb

Line 13 in a790203

ActiveStorage::Blob.service.try(:mirror, key, checksum: checksum)

ActiveStorage::Blob.service the default service. The other jobs pass blob to perform... Is there any reason not to pass blob here as well, and use blob.service instead of ActiveStorage::Blob.service?

If that's acceptable I'm happy to submit a PR. Thanks!

[ghiculescu]

Yep that looks like a bug. Please submit a PR! You could add a test to verify the fix here.

[jnimety]

I'm unfamiliar with the rails PR process... is there anything else I need to do to move this forward?

[skipkayhil]

Your best bet is probably asking for a review in the Contributor Discord