ActiveStorage::MirrorJob should honor the service: option
#46825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghiculescu
reviewed
Jan 4, 2023
| @@ -9,7 +9,7 @@ class ActiveStorage::MirrorJob < ActiveStorage::BaseJob | |||
| discard_on ActiveStorage::FileNotFoundError | |||
| retry_on ActiveStorage::IntegrityError, attempts: 10, wait: :exponentially_longer | |||
|
|
|||
| def perform(key, checksum:) | |||
| ActiveStorage::Blob.service.try(:mirror, key, checksum: checksum) | |||
| def perform(blob) | |||
There was a problem hiding this comment.
This isn’t backward compatible (if existing jobs are queued when you update rails). I think you’d need to write this in a way that supports both the new and old arguments. The old form can get deprecated and removed in the next rails release.
There was a problem hiding this comment.
good point @ghiculescu. I've updated the PR to use the existing method signature.
jnimety
force-pushed
the
active-storage-mirror-job-incorrect-service
branch
2 times, most recently
from
e5d459a
to
f02cf13
Compare
jnimety
force-pushed
the
active-storage-mirror-job-incorrect-service
branch
from
f02cf13
to
d52d9aa
Compare
|
Would love to get this merged so I can remove my local patch. Anything left other than a final code review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes #46806
This Pull Request has been created because
ActiveStorage::MirrorJobalways uses the global/default service, even if an alternate service was specified via the:serviceoption forhas_*_attachedDetail
This Pull Request changes
ActiveStorage::MirrorJobso the blob's service can be used to find mirrors instead of always using the global/default service.Additional information
n/a
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]