Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use :rubygems shortcut as standard Gemfile's source instead of explicit URL #4684

Merged
merged 1 commit into from Jan 26, 2012

Conversation

rossmeissl
Copy link
Contributor

Theoretically this would future-proof Gemfiles against possible (albeit unlikely) change in the rubygems URL.

Documentation

…plicit URL.


Theoretically this would future-proof Gemfiles against possible (albeit unlikely) change in the rubygems URL.
fxn added a commit that referenced this pull request Jan 26, 2012
Use `:rubygems` shortcut as standard Gemfile's `source` instead of explicit URL
@fxn fxn merged commit c6efa0d into rails:master Jan 26, 2012
@stve
Copy link
Contributor

stve commented Jan 26, 2012

Using :rubygems in the Gemfile means that it's actually accessing http://rubygems.org instead of https. I'd like to propose that we revert this change as I think https is a better default. Thoughts?

FYI - Some time back I had submitted a pull request to bundler to change the default usage of :rubygems to be https but it was not merged due to SemVer. More info here: rubygems/bundler#1585

@qrush
Copy link
Contributor

qrush commented Jan 26, 2012

There's honestly no benefit to using HTTPS when requesting rubygems. I don't see why the argument is made one way or another here.

sgerrand pushed a commit to sgerrand/rails that referenced this pull request Nov 2, 2013
…ygems"

This reverts commit 33b29e0, reversing
changes made to ac8c729.

Reason:

rails#4684 (comment)
brigade-gerrit pushed a commit to causes/rails that referenced this pull request Nov 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants