Improve Rails' Shape friendliness (second pass) #47032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rails-bot
bot
added
actionpack
actionview
activemodel
activerecord
activesupport
labels
byroot
commented
Jan 17, 2023
| @@ -205,7 +205,8 @@ def changed?(other) # :nodoc: | |||
| delegate :formats, :formats=, :locale, :locale=, :view_paths, :view_paths=, to: :lookup_context | |||
|
|
|||
| def assign(new_assigns) # :nodoc: | |||
| @_assigns = new_assigns.each { |key, value| instance_variable_set("@#{key}", value) } | |||
| @_assigns = new_assigns | |||
| new_assigns.each { |key, value| instance_variable_set("@#{key}", value) } | |||
There was a problem hiding this comment.
I think ActionView::Base will inevitably be marked has having too many shapes, but at least we can keep a common root...
cc @tenderlove what do you think?
casperisfine
force-pushed
the
shapes-friendliness-2
branch
3 times, most recently
from
f805f77
to
038835d
Compare
Followup: rails#47023 ``` Shape Edges Report ----------------------------------- snip... 238 @errors snip... 219 @options snip... 129 @_request 128 @type 125 @virtual_path 124 @_assigns 123 @_config 123 @_controller 123 @output_buffer 123 @view_flow 122 @_default_form_builder snip... 89 @_already_called 75 @validation_context snip... 65 @_new_record_before_last_commit snip... 58 @_url_options snip... ```
casperisfine
force-pushed
the
shapes-friendliness-2
branch
from
038835d
to
aa7d78d
Compare
Based on a production heap dump, I noticed that while they didn't appear in the most common shape edges, reflections classes were marked as having 8 or more variations. This means they are marked as "too_complex" by MRI and fallback to not using shapes for instance variable access.
|
ActionText test suite is broken, but that's unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup: #47023