deferrable foreign key can be passed to references #47671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpaca-tc
force-pushed
the
references_with_deferrable_foreign_key
branch
2 times, most recently
from
38010c9
to
512b8b2
Compare
9 tasks
alpaca-tc
commented
Mar 14, 2023
| @@ -84,6 +84,8 @@ def visit_ForeignKeyDefinition(o) | |||
| FOREIGN KEY (#{quote_column_name(o.column)}) | |||
| REFERENCES #{quote_table_name(o.to_table)} (#{quote_column_name(o.primary_key)}) | |||
| SQL | |||
|
|
|||
| sql << " DEFERRABLE INITIALLY #{o.deferrable.to_s.upcase}" if o.deferrable | |||
There was a problem hiding this comment.
NOTE: This PR needs to be merged after #47659 because the return value of ForeignKeyDefinition#deferrable will be changed.
|
Let's consider this pull request adds a feature with changelog. |
alpaca-tc
force-pushed
the
references_with_deferrable_foreign_key
branch
from
512b8b2
to
7dd0607
Compare
yahonda
reviewed
Apr 27, 2023
Fixed a bug in which deferrable foreign_key was ignored when passed to `t.references`.
alpaca-tc
force-pushed
the
references_with_deferrable_foreign_key
branch
from
7dd0607
to
ec0a2a9
Compare
|
@yahonda fixed 💛 |
yahonda
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixed a bug in where deferrable foreign_key was ignored when passed to
t.referencesDetail
This PR is a follow-up to #41487 .
#41487 supports the
deferrableoption foradd_foreign_keybutt.referencesdoes not yet support thedeferrableoption yet.I think this is just an omission in the implementation.
Additional information
This PR needs to be merged after #47659 because the return value of
ForeignKeyDefinition#deferrablewill be changed.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]