Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deferrable foreign key can be passed to references #47671

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions activerecord/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
* The deferrable foreign key can be passed to `t.references`.

*Hiroyuki Ishii*

* Deprecate `deferrable: true` option of `add_foreign_key`.

`deferrable: true` is deprecated in favor of `deferrable: :immediate`, and
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ def visit_AddForeignKey(o)
end
end

def visit_ForeignKeyDefinition(o)
super.dup.tap do |sql|
sql << " DEFERRABLE INITIALLY #{o.deferrable.to_s.upcase}" if o.deferrable
end
end

def visit_CheckConstraintDefinition(o)
super.dup.tap { |sql| sql << " NOT VALID" unless o.validate? }
end
Expand Down
42 changes: 42 additions & 0 deletions activerecord/test/cases/migration/references_foreign_key_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,48 @@ class ReferencesForeignKeyInCreateTest < ActiveRecord::TestCase
assert_equal([["testings", "testing_parents", "parent_id"]],
fks.map { |fk| [fk.from_table, fk.to_table, fk.column] })
end

if current_adapter?(:PostgreSQLAdapter)
test "deferrable: false option can be passed" do
@connection.create_table :testings do |t|
t.references :testing_parent, foreign_key: { deferrable: false }
end

fks = @connection.foreign_keys("testings")
assert_equal([["testings", "testing_parents", "testing_parent_id", false]],
fks.map { |fk| [fk.from_table, fk.to_table, fk.column, fk.deferrable] })
end

test "deferrable: :immediate option can be passed" do
@connection.create_table :testings do |t|
t.references :testing_parent, foreign_key: { deferrable: :immediate }
end

fks = @connection.foreign_keys("testings")
assert_equal([["testings", "testing_parents", "testing_parent_id", :immediate]],
fks.map { |fk| [fk.from_table, fk.to_table, fk.column, fk.deferrable] })
end

test "deferrable: :deferred option can be passed" do
@connection.create_table :testings do |t|
t.references :testing_parent, foreign_key: { deferrable: :deferred }
end

fks = @connection.foreign_keys("testings")
assert_equal([["testings", "testing_parents", "testing_parent_id", :deferred]],
fks.map { |fk| [fk.from_table, fk.to_table, fk.column, fk.deferrable] })
end

test "deferrable and on_(delete|update) option can be passed" do
@connection.create_table :testings do |t|
t.references :testing_parent, foreign_key: { on_update: :cascade, on_delete: :cascade, deferrable: :immediate }
end

fks = @connection.foreign_keys("testings")
assert_equal([["testings", "testing_parents", "testing_parent_id", :cascade, :cascade, :immediate]],
fks.map { |fk| [fk.from_table, fk.to_table, fk.column, fk.on_delete, fk.on_update, fk.deferrable] })
end
end
end
end
end
Expand Down