Store secret_key_base in Rails.config for local environments.
#48470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
railties/use-secret-key-base-accessor
branch
from
81f7f6e
to
9aba812
Compare
p8
changed the title
secret_key_base in Rails.config for local environments.secret_key_base in Rails.config for local environments.
p8
force-pushed
the
railties/use-secret-key-base-accessor
branch
3 times, most recently
from
0631668
to
fdb3f33
Compare
4 tasks
p8
force-pushed
the
railties/use-secret-key-base-accessor
branch
from
fdb3f33
to
a87e5e3
Compare
Rails `secrets` have been deprecated in favor of `credentials`. For the local environment the `secret_key_base` is now be stored in `Rails.config.secret_key_base` instead of the deprecated `Rails.application.secrets.secret_key_base`.
p8
force-pushed
the
railties/use-secret-key-base-accessor
branch
from
a87e5e3
to
21c3455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails
secretshave been deprecated in favor ofcredentials.However, for the local environments
Rails.application.secretsis still used to storesecret_key_base.We can store
secret_key_baseinRails.config.secret_key_baseinstead.This change allows us to deprecate calling
Rails.application.secrets. See #48472.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]