Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate calling Rails.application.secrets #48472

Merged

Conversation

p8
Copy link
Member

@p8 p8 commented Jun 14, 2023

Rails secrets have been deprecated in favor of credentials. Calling Rails.application.secrets should show a deprecation warning.

This requires #48470 which removes most internal calls to Rails.application.secrets.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

@rails-bot rails-bot bot added the railties label Jun 14, 2023
@p8 p8 force-pushed the railties/deprecate-rails-config-secrets branch 2 times, most recently from 05eb6a5 to 43e412a Compare June 14, 2023 13:11
@p8 p8 changed the title Deprecate calling Rails.application.secrets. Deprecate calling Rails.application.secrets Jun 14, 2023
@guilleiguaran
Copy link
Member

I merged #48470, please rebase this

Rails `secrets` have been deprecated in favor of `credentials`.
Calling `Rails.application.secrets` should show a deprecation warning.
@p8 p8 force-pushed the railties/deprecate-rails-config-secrets branch from 43e412a to 9f9b540 Compare June 15, 2023 06:42
@guilleiguaran guilleiguaran merged commit e10e35d into rails:main Jun 15, 2023
8 of 9 checks passed
@p8 p8 deleted the railties/deprecate-rails-config-secrets branch June 15, 2023 07:22
@p8
Copy link
Member Author

p8 commented Jun 15, 2023

Thanks @guilleiguaran !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants