Use _read_attribute when autosaving has_one associations #48489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because composite primary key models do not autosave properly when their association primary key is set to
:id
. In models with composite primary keys, the#id
accessor will return an array, where we actually want the id column value.Detail
This Pull Request changes has_one autosaving to use
_read_attribute
instead ofpublic_send
so that it won't use the#id
accessor.Additional information
Are we concerned with this breaking behaviour of existing apps?
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]