Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning messages for ActiveSupport::TestFixtures #48519

Conversation

adrianna-chang-shopify
Copy link
Contributor

Motivation / Background

While reviewing @zzak 's documentation improvements around fixture paths, I noticed a few minor inconsistencies with the deprecation messages.

Detail

Minor fixes to the deprecation messages around TestFixtures.fixture_path, TestFixtures.fixture_path=, and TestFixtures#fixture_path to clarify which method is deprecated and which should be used instead.

Ensure we refer to the class method vs instance method appropriately, and refer to the setter method in the deprecation method for TestFixtures.fixture_path=.

cc @andrewn617

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]

Minor fixes to the deprecation messages around TestFixtures.fixture_path,
TestFixtures.fixture_path=, and TestFixtures#fixture_path to clarify
which method is deprecated and which should be used instead.
@gmcgibbon gmcgibbon merged commit 51f2e2f into rails:main Jun 19, 2023
8 of 9 checks passed
@adrianna-chang-shopify adrianna-chang-shopify deleted the ac-tweak-fixture-path-deprecations branch June 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants