Add support for nullifying composite primary key has_one associations #48539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmcgibbon
force-pushed
the
fix_cpk_nullify
branch
from
110b59d
to
d963c58
Compare
|
The Railties failure will be fixed by a rebase. Can you fix the rubocop failures? |
Composite primary key records need to conditionally unset multiple column attributes from the associated record in order to properly support dependent: nullify.
gmcgibbon
force-pushed
the
fix_cpk_nullify
branch
from
d963c58
to
622485a
Compare
|
Done. Looks like we're green now! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because
has_oneCPK associations withdependent: :nullifydon't currently work.Detail
This Pull Request changes the nullification code in
ActiveRecord::Associations::HasOneAssociationto iterate through foreign key columns and nullify them if they don't belong to the model's primary keys.Additional information
I had to add an extra test model to make a scenario where part of a composite primary key shouldn't be nullified. Does it make sense?
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]