Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of unnecessary gem "minitest" calls #48544

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

amatsuda
Copy link
Member

This patch simply removes unnecessary gem activations of minitest.

Motivation / Background

minitest used to be a CRuby's stdlib from Rubies >= 1.9.1 to < 2.2.0.
And the gem 'minitest' call in the Rails codebase was added at 6f74d36 because at that time require 'minitest' could load either a gem version or the stdlib one, and we wanted to make sure not to load the stdlib minitest.

2.years.since then, CRuby's bundled minitest had been removed in 2.2.0 at ruby/ruby@7cda822
and now that Ruby < 2.2 is no longer supported in Rails 7, we can just safely drop this gem "minitest" call in favor of simple require that is already written there.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Changes that are unrelated should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]

…bies

CRuby's bundled minitest had been removed in 2.2.0 at
ruby/ruby@7cda822
@guilleiguaran guilleiguaran merged commit 860967d into rails:main Jun 21, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants