Get rid of unnecessary gem "minitest"
calls
#48544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simply removes unnecessary
gem
activations of minitest.Motivation / Background
minitest used to be a CRuby's stdlib from Rubies
>= 1.9.1
to< 2.2.0
.And the
gem 'minitest'
call in the Rails codebase was added at 6f74d36 because at that timerequire 'minitest'
could load either a gem version or the stdlib one, and we wanted to make sure not to load the stdlib minitest.2.years.since then, CRuby's bundled minitest had been removed in 2.2.0 at ruby/ruby@7cda822
and now that Ruby < 2.2 is no longer supported in Rails 7, we can just safely drop this
gem "minitest"
call in favor of simplerequire
that is already written there.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]