Use a consistent format when testing BigDecimal.to_s #48693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, it seems like it's due to ruby/bigdecimal#264 👀 |
zzak
force-pushed
the
bigdecimal-to_s
branch
2 times, most recently
from
c071d09
to
f0721bc
Compare
|
We can just switch to a number that formats consistently ( Honestly I'm not sure |
The previous examples were causing failures in CI, after ruby/bigdecimal#264 was merged. For example: ``` Failure: NumericExtFormattingTest#test_default_to_fs [/rails/activesupport/test/core_ext/numeric_ext_test.rb:446]: --- expected +++ actual @@ -1 +1,3 @@ -"10000 10.0" +# encoding: US-ASCII +# valid: true +"10 00010.0" ``` The recommendation was to adjust the test to deal with the upstream change more flexibly.
zzak
changed the title
zzak
pushed a commit
to zzak/rails
that referenced
this pull request
Jul 12, 2023
Use a consistent format when testing BigDecimal.to_s
skipkayhil
pushed a commit
to skipkayhil/rails
that referenced
this pull request
Jan 8, 2024
Use a consistent format when testing BigDecimal.to_s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous examples were causing failures in CI, after ruby/bigdecimal#264 was merged.
For example:
The recommendation was to adjust the test to deal with the upstream change more flexibly.