Improve cpk validation check #48724
Merged
Improve cpk validation check #48724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches more bugs in CPK assocaitions by validating the shape of keys on both ends of the association. Co-authored-by: Nikita Vasilevsky <nikita.vasilevsky@shopify.com>
Support assignment of belongs_to associations with query constraints. This improves errors messages for composite key mismatches, and some edge cases with query constraint lists. Co-authored-by: Nikita Vasilevsky <nikita.vasilevsky@shopify.com>
A developer may not always want to specify query constraints. If, for example they would like to use a non-composite primary key in an asscoaition, they need to use primary_key/foreign_key options instead. Co-authored-by: Nikita Vasilevsky <nikita.vasilevsky@shopify.com>
gmcgibbon
force-pushed
the
improve_cpk_validation_check
branch
from
28069f6
to
ab04511
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because the composite primary key validation check is incomplete. It only checks for one side of the association having a CPK. It should actually check both sides so that more edge cases are caught.
Detail
This Pull Request changes the CPK validation check condition to include
active_record.composite_primary_key?, which account for CPK owners of associations (not just CPK association classes).Additional information
This PR also changes a few other things in other commits. It improves the CPK validation check error message, and changes
<reflection>.association_primary_keybehaviour to better support CPK. The fix for belongs_to assignment included in the#association_primary_keychange commit doesn't appear to be released, so I don't think a changelog is needed there.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]