Add Rack::Lint to ActionDispatch::ShowExceptions tests
#48842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure is due to a hardcoded Does #47108 still make sense to merge ahead of adding |
|
I think we should just fix the header here. The conditional header strategy should obsolete #47108 |
adrianna-chang-shopify
force-pushed
the
ac-rack-lint-show-exceptions
branch
from
dae43c7
to
ca254d4
Compare
|
Done 👍 Happy to pull the router-related changes out to a separate PR if that would be more appropriate. |
|
Ah, it's going to require changes to more than just |
This wraps test coverage for `ActionDispatch::ShowExpections` in `Rack::Lint` middleware in order to validate that both `ActionDispatch::ShowExceptions` and `ActionDispatch::PublicExceptions` conform to the Rack SPEC. It also ensures that the response headers returned by the *Exceptions middleware respect casing (mixed case for Rack 2, lower case for Rack 3)
adrianna-chang-shopify
force-pushed
the
ac-rack-lint-show-exceptions
branch
from
ca254d4
to
339dda4
Compare
|
@guilleiguaran this should be ready to go now, thanks! |
|
Ref #48874 (linking to keep everything together) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This wraps test coverage for
ActionDispatch::ShowExpectionsinRack::Lintmiddleware in order to validate that bothActionDispatch::ShowExceptionsandActionDispatch::PublicExceptionsconform to the Rack SPEC.It also ensures that the response headers returned by the *Exceptions middleware respect casing (mixed case for Rack 2, lower case for Rack 3).
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]