support lower case x-cascade headers in the router #47108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's another one here: https://github.com/rails/rails/blob/main/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb#L29 |
|
Yes. Let's fix all of them in the same PR. |
lsylvester
force-pushed
the
support-lower-case-x-cascade-headers
branch
from
593f046
to
9f9104d
Compare
|
@rafaelfranca I have updated with a fix for debug exceptions, and also another case in show exceptions. I think that this every instance where the X-Cascade header was being checked in a case-sensitive way. The lint errors seem to be unrelated - as they appear to be referring to issues within trix which have not been changed as part of this PR, and the failure appears to be affecting other recent PRs. |
lsylvester
force-pushed
the
support-lower-case-x-cascade-headers
branch
from
9f9104d
to
97d222e
Compare
ioquatix
reviewed
Feb 6, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
As part of the change in the spec for Rack for Rack 3.0 - the headers are now expected to be lower case.
This was updated in sprockets in rails/sprockets#758, but when using the
X-Cascadeheader we are currently checking a case sensitive version which causes the cascade to fail, as identified in #47096.This PR updates the logic for detecting the cascade header to be case insensitive and fixes #47096.
Detail
This Pull Request changes the detection of the
X-Cascadeheader in the router to be case insensitive.Additional information
The implementation may be able to be simplified using the
ActionDispatch::Response::Headeronce #47091 is merged, but I am not sure of the timing for when that would be merged, and we may want to backport a fix for this issue without needing to backport #47091.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]I think that this is a minor bug fix - so I have not included a CHANGELOG entry. I am happy to add one if you think it is required.