Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor actions to make fewer status checks #48919

Merged
merged 1 commit into from Aug 22, 2023

Conversation

zzak
Copy link
Member

@zzak zzak commented Aug 10, 2023

This flattens our workflow graph from 8 checks to just 3.

By compacting the lint jobs into a single job inside a single workflow, we maybe lose some readability -- but since the cost to maintain those files is already really low, they are rarely changed, versus the number of checks on each PR makes for a worse experience IMO.

This also means that all of those separate checks can be found on a single page (e.g. here), for better or worse.. navigating the actions UI across multiple workflows and jobs is already strenuous. There is an argument that if one of these steps fails, debugging it there may be difficult, but I've tried to order them in terms of priority of "if this step fails it should fail first".

If any of the Lint steps fails, figuring out which one and why may not be as straight-forward, that maybe the only downside here. There are plans to move this workflow entirely to Buildkite at some point, probably after a refactor (rails/buildkite-config#62, where they can go back to being separate "jobs" in that context and all of the important stuff is in a single place.

So this is more of an intermediary step to improve the PR page and hopefully make reviewing them and deciding which checks failed matters, more efficient.

@zzak zzak force-pushed the actions-refactor branch 2 times, most recently from c226528 to 26ee776 Compare August 10, 2023 23:05
@zzak zzak force-pushed the actions-refactor branch 6 times, most recently from 8eb277f to 936aaf4 Compare August 22, 2023 02:48
@matthewd matthewd merged commit 36ebb6b into rails:main Aug 22, 2023
4 checks passed
@zzak zzak deleted the actions-refactor branch August 22, 2023 05:16
@zzak zzak restored the actions-refactor branch August 22, 2023 06:11
@zzak zzak deleted the actions-refactor branch August 22, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants