Use zzak/action-discord@v8 #49008
Merged
Use zzak/action-discord@v8 #49008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed 'fixed/still failing' modes * Only runs when failure() step * Include GITHUB_TOKEN to prevent rate-limits * Need to reset BUNDLE_ONLY on rubocop job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes notifications from #48919
There is some more context if necessary in zzak/action-discord#7 and zzak/action-discord@v8.
Basically, I tried to "hide" the
BUNDLE_ONLYpart of rubocop inside of the action, but failed to do so without spending a ton of time trying to hack it.Lastly, because we are only using this action as a step to notify when a job fails, it could be greatly simplified and just make that the only use-case for this action. It wasn't worth trying to support multiple modes for me.