Fix form_for id generation for new CPK models #49069
Merged
+42
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because dom ID generation for CPK models is subtly broken.
Detail
This Pull Request changes Action View by adding tests for form_for when using composite primary key models and fixes
dom_id
output for new CPK models.Additional information
Every record key casting is either going to be nil or an array, so the code should be safe.
Also, I removed the original
CompositePrimaryKeyRecord
because it didn't follow the existing pattern of using example-based models in tests. As a result, I updated the test using it to use the new fake CPK model.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]